Conversation
Python truth values can't be used for presence checks of embedded protobuf message fields. Use `HasField()` instead. This prevents passing invalid digests to the Remote Asset server. Fixes #2090.
The source digest is already stored in the artifact proto and added to the list of referenced directories if the buildtree is cached, however, the actual push and fetch was missing.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
Contributor
|
I have tested this PR locally and artifact pushes passes the Thanks! |
gtristan
approved these changes
Nov 21, 2025
Contributor
gtristan
left a comment
gtristan
left a comment
There was a problem hiding this comment.
Great. Looks good to me !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_artifactcache.py: Fix presence checks of protobuf digest fields
Python truth values can't be used for presence checks of embedded protobuf message fields. Use
HasField()instead. This prevents passing invalid digests to the Remote Asset server.Fixes Artifact caching uploading empty/invalid referenced_directories #2090.
_artifactcache.py: Add
public_datato list of referenced blobs_artifactcache.py: Push and fetch sources
The source digest is already stored in the artifact proto and added to the list of referenced directories if the buildtree is cached, however, the actual push and fetch was missing.